1941911 - No alert for Inbox on new messages if messages are moved via filter under certain circumstances (POP, non-Windows alerts)

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Francesco]

In the following setup:

• POP account
• Using TB notifications (not system notification)
• Move certain messages from Inbox to another folder

there is no longer a notification on the Inbox when two or more messages arrive, some being filtered to the non-inbox folder, some left in the inbox.

Notification debugging shows Filling alert info; folder.URI= for both mailboxes, however, only one alert is displayed.

Note that the non-inbox alert was introduced in bug 1836511.

Tested in 135.0b1.

Comment 1

[Geoff Lankow (:darktrojan)]

Okay, I know what's happened here.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941911 - Simplify new mail notification dispatcher. r=#thunderbird-reviewers

We no longer support Windows 7, which is the only platform that needed to fall back to the custom
notification when there was no system notification. So I've removed the fall back code, which means
we only use the custom notification if the preferences say so.

This makes it easier to fix the notification time recording when using the custom notification.
Previously the time was recorded when the mail arrived but it should be when the notification
actually happened. Custom notifications get queued when more than one folder gets new mail. It's
these queued folders that had the problem.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/578b25792b7f
Simplify new mail notification dispatcher. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9459815 [details]
Bug 1941911 - Simplify new mail notification dispatcher. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1926462
User impact if declined: Users might not be notified about some new messages if messages in more than one folder arrive at once
Testing completed (on c-c, etc.): landed 5 days ago
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Corey Bryant]

Comment on attachment 9459815 [details]
Bug 1941911 - Simplify new mail notification dispatcher. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 135.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/afb010de4b94