1941942 - [wpt-sync] Sync PR 50110 - Remove expected PNG files for generated OffscreenCanvas tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50110 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50110
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Remove expected PNG files for generated OffscreenCanvas tests

These expected images have very limited value. They are only used for
testharness tests and are not used for automatically validating the
test results. These tests are instead validated using assertions. Thus,
the expected image is only useful for manual verifications. For element
tests, test result pages include both the canvas test result and the
expected image, and thus, we can manually validate the test result
visually.

For offscreen and worker tests however, the test result is never
captured from the OffscreenCanvas and never displayed in any way. It's
therefore impossible to use the expected image for verification, making
it entirely useless.

Originally, the expected images almost only existed for element tests
(see the state of the tests in https://crrev.com/c/2240038 for
instance). As we merged the test definition for element and offscreen,
lots of offscreen tests mistakenly inherited the element's expected
image (see https://crrev.com/c/4562936 for instance). It's time to
clean this up.

Bug: 40207206
Change-Id: I97a483ce929f7e346c8062f5ab6b6efdd6c5449d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172745
Commit-Queue: Jean-Philippe Gravel \<[e-mail]>
Reviewed-by: Yi Xu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1406971}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5dfe3a39f7ea190576eeba2adde5b4914fc2b48

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6485f10d83b5
[wpt PR 50110] - Remove expected PNG files for generated OffscreenCanvas tests, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6485f10d83b5