1941947 - Support non-index doubles as property keys in CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Description

[Iain Ireland [:iain]]

After bug 1932864, there are only a few types that are not supported as property keys by CacheIR: objects, BigInts, and doubles. Doubles show up in small numbers in sp3, so it's probably worth adding support.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1941947: Support Address in branchTestValue r=jandem

We previously only had support for comparing a Value against a constant or BaseIndex.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1941947: Add GuardSpecificValue r=jandem

Instead of unboxing a value and then using a second branch to test its payload, it seems better to do a single 64-bit comparison.

This will also be used in the next patch to handle doubles.

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1941947: Handle non-index doubles as property keys r=jandem

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b056911064c0
Support Address in branchTestValue r=jandem
https://hg.mozilla.org/integration/autoland/rev/6368dfc3256c
Add GuardSpecificValue r=jandem
https://hg.mozilla.org/integration/autoland/rev/8f2b32df275c
Handle non-index doubles as property keys r=jandem

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b056911064c0
https://hg.mozilla.org/mozilla-central/rev/6368dfc3256c
https://hg.mozilla.org/mozilla-central/rev/8f2b32df275c