1942018 - Object/embed elements embedding cross-origin images aren't always clickable.

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Andreas Farre [:farre]]

object/embed element in an anchor embedding an image is only clickable if the mouse enters the image from below.

Comment 1

[Andreas Farre [:farre]]

See the video in bug 1935609 comment 15.

This depends on having the changes from 1935609.

Comment 2

[Andreas Farre [:farre]]

Sorry for bugging you again about this, but I'm trying to figure out which component that causes this error. It might be DOM: Core, but I'm not sure. Any help finding the right person to tackle this is appreciated.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

It is clickable tho, right? It's just the cursor that's wrong? At least that was what happened with the patches in bug 1935609...

If so I'd look at EventStateManager::SetCursor to see which frame are we getting the cursor from.

Comment 4

[Andreas Farre [:farre]]

It looks like it's EventStateManager::UpdateCursor that makes us behave in different ways. Entering from below this will update the cursor for an nsInlineFrame as target and if we leave the inline to enter the nsSubDocumentFrame, then EventStateManager::UpdateCursor won't reset the cursor (which makes it behave as expected). Entering from the top makes the nsSubDocumentFrame be the target, which means it stays a regular pointer.

Edgar, you added this check, do you have an idea of what's going on?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Ahh... So this check you linked to is wrong / has to check whether the remote content reacts to pointer events.

So probably it should be:

if (nsSubDocumentFrame* f = do_QueryFrame(aTargetFrame)) {
  if (auto* fl = f->FrameLoader(); fl && fl->IsRemoteFrame() && f->ContentReactsToPointerEvents()) {
    // The sub-frame will update the cursor if needed.
    return;
  }
}

Comment 6

[Edgar Chen [:edgar]]

Emilio's comment #5 should work. Yes, in this case we should not let remote content to update cursor and we don't actually forward the event to the remote content.

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1942018 - Don't forward cursor update to the remote content that doesn’t handle pointer events; r=farre,emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da0d0fe1351b
Don't forward cursor update to the remote content that doesn’t handle pointer events; r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/da0d0fe1351b