1942021 - aboutRights has non-functioning margin-left due to CSP

Status: RESOLVED FIXED

(Toolkit :: General, defect, P5)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/b19c379ba7b6d4f25af090a66cec3facf8153ee3/toolkit/content/aboutRights.xhtml#86

<div id="disabling-webservices-container" style="margin-left: 40px">

doesn't work because of

https://searchfox.org/mozilla-central/rev/b19c379ba7b6d4f25af090a66cec3facf8153ee3/toolkit/content/aboutRights.xhtml#13

content="default-src chrome:; object-src 'none'"

and triggers:

Content-Security-Policy: The page’s settings blocked an inline style (style-src-attr) from being applied because it violates the following directive: “default-src chrome:”
Source: margin-left: 40px

in the devtools console.

There are a few other CSP style related errors as well that are less easy to track down. Also, the margin should probably be using inline-start...

Comment 1

[:Gijs (he/him)]

Oops, wrong regressor.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1453933

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1942021 - fix CSP violations in about:rights and make the code nicer, r?darktrojan

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c54e237cf6de
fix CSP violations in about:rights and make the code nicer, r=darktrojan,desktop-theme-reviewers,dao

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c54e237cf6de