1942030 - nsStandarURL.setHost("") is throws for URLTYPE_STANDARD

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin]]

This was regressed by bug 996055.

https://searchfox.org/mozilla-central/rev/b19c379ba7b6d4f25af090a66cec3facf8153ee3/netwerk/base/nsIStandardURL.idl#20-26

/**
 * blah:foo/bar    => blah://foo/bar
 * blah:/foo/bar   => blah:///foo/bar
 * blah://foo/bar  => blah://foo/bar
 * blah:///foo/bar => blah:///foo/bar
 */
const unsigned long URLTYPE_STANDARD        = 1;

URLTYPE_STANDARD is defined as "may or may not have a hostname".
As such, it's weird that we may parse a URL without a hostname, set the hostname to something, but not be able to clear it.

The fix is to update the condition to only throw for URLTYPE_AUTHORITY here and update the test expectation

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1942030 - nsStandarURL.setHost("") throws for URLTYPE_STANDARD r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e95cc87f0db1
nsStandarURL.setHost("") throws for URLTYPE_STANDARD r=necko-reviewers,kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23fd0c10f9a7
nsStandarURL.setHost("") throws for URLTYPE_STANDARD r=necko-reviewers,kershaw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/23fd0c10f9a7