1942031 - Bad canvas performance on this example (nokiadesignarchive.aalto.fi)

Status: NEW

(Core :: Graphics: Canvas2D, defect)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I was looking at a website and noticed that its performance is pretty bad. When I tried it on Chrome, it's a lot smoother on macOS.

STR:

• Visit https://nokiadesignarchive.aalto.fi/
• Close any popups if they appear.
• Try to drag the canvas by holding on your mouse and just trying to move around.

Actual result: it's very janky.
Expected result: it should be smoother

Here's a profile I captured: https://share.firefox.dev/4ajRHYx
CanvasRenderer thread appears to have lots of activity with some jank markers in the parent process. The website itself doesn't seem to have lots of JS activity.

Comment 1

[Ashley Hale [:ahale]]

Lee, do you have thoughts on this? Looks like buffer access patterns are causing a lot of waiting?

Comment 2

[Bas Schouten (:bas.schouten)]

This was regressed by bug 1910138.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Hm, I initially noticed this issue on macOS. I don't think this is a Windows-only regression.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910138

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910138

Comment 6

[Lee Salzman [:lsalzman]]

The performance issue with acceleration seems to be that it is doing a lot of stroke operations that use dash patterns. By itself, this is not a problem if the draw operations are cached, but because it is continually changing the transform underneath the dashed strokes, it is defeating the caching so that it is regenerating a fallback image for it every time. Performance it would make sense to fall back more completely in such cases if it is overall slower than with acceleration disabled, but that is to be determined.

Comment 7

[Bas Schouten (:bas.schouten)]

The Performance Impact Calculator has determined this bug's performance impact to be low. If you'd like to request re-triage, you can reset the Performance Impact flag to "?" or needinfo the triage sheriff.

Platforms: [x] Windows [x] macOS
Impact on site: Causes noticeable jank
Websites affected: Rare
[x] Able to reproduce locally