1942036 - scrollWidth / scrollHeight not properly calculated when content has negative margin

Status: NEW

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Manuel Irrschik]

Attachment: marginTest.html

Steps to reproduce:

For the attached case, the contentWidth/Height and scrollWidth/Height should be equals (and were till FF133, and still are in chrome/edge) - but since v134 the values are wronlgy caluclated, assumingly because of incorrect handling of the negative margins.

Actual results:

scrollWidth/scrollHeight is wrong (310 in my test-case)

Expected results:

scrollWidth/scrollHeight should be 300 in my test-case

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dc12acb51f96b585efb881cf95c2dd3452fe23a6&tochange=a661bff10b1fea7e6d828efad298bbdbe2a8574c

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1936156, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1942036 - Don't ignore negative margins for scroll{Width,Height} on overflow:visible frames. r=dshin,#layout

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks for the report! FYI, in case you've encountered this in a site you develop or what not, a potential workaround is to use display: flow-root, or something that turns the block into a block formatting context.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87e1173b9098
Don't ignore negative margins for scroll{Width,Height} on overflow:visible frames. r=dshin

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50151 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/e1e29a88000d0dbbb33b2e0f8c75a096dbe718b8

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | widget/tests/test_wheeltransaction.xhtml

INFO - TEST-UNEXPECTED-FAIL | widget/tests/test_wheeltransaction.xhtml | Test timed out. - 
[task 2025-01-17T19:10:59.514Z] 19:10:59     INFO - GECKO(1619) | MEMORY STAT | vsize 20137MB | residentFast 626MB | heapAllocated 289MB
[task 2025-01-17T19:11:02.531Z] 19:11:02     INFO - Error: Unable to restore focus, expect failures and timeouts.
[task 2025-01-17T19:11:02.532Z] 19:11:02     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:182
[task 2025-01-17T19:11:02.533Z] 19:11:02     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/chrome/nsChromeProtocolHandler.cpp:73
[task 2025-01-17T19:11:02.546Z] 19:11:02     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1215
[task 2025-01-17T19:11:02.606Z] 19:11:02     INFO - TEST-OK | widget/tests/test_wheeltransaction.xhtml | took 323690ms

Failure log -> REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/position-sticky/padding-3.html == layout/reftests/position-sticky/padding-3-ref.html | image comparison, max difference: 54, number of differing pixels: 234

Failure log -> TEST-UNEXPECTED-FAIL | /css/css-flexbox/scrollbars-auto.html & TEST-UNEXPECTED-FAIL | /css/css-flexbox/scrollbars-no-margin.html

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Blerg, typo, accounted for the normal position twice accidentally in one code-path.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f6d1963e0e0
Don't ignore negative margins for scroll{Width,Height} on overflow:visible frames. r=dshin

Comment 11

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures in scrollWidthHeight-overflow-visible-negative-margins.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /css/cssom-view/scrollWidthHeight-overflow-visible-negative-margins.html | scroll{Width,Height} with negative margins with overflow: auto, padding: 2px, border: 0, display: flex - assert_equals: scrollWidth expecting 5px of overflow expected 14 but got 15

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d291e613ef7b
Don't ignore negative margins for scroll{Width,Height} on overflow:visible frames. r=dshin

Comment 14

[agoloman]

Backed out for causing wpt failures in scrollWidthHeight-overflow-visible-negative-margins.html.

• Backout link
• Push with failures
• Failure Log

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging