1942117 - Text-Fragments: Add use counters and performance telemetry

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Jan Jaeschke [:jjaschke]]

Now that Text Fragments and creating Text Fragments is feature-complete, there should be some telemetry probes added to measure its usage and performance impact.

Things that should be logged:

• Counter for pages that have a fragment directive
• Time spent in TextDirectiveFinder::FindTextDirectivesInDocument() (per page load. This function might be called several times)
• How many text directives were in the URL? This can be found out by the length of the returned array of TextDirectiveFinder::FindTextDirectivesInDocument(); again, this function might be called several times.
• Amount of pages where a text directive cannot be found after loading has finished (can be checked by checking for FragmentDirective::HasUninvokedDirectives() after Document::ScrollToRef(). Note: Not 100% sure this is the right place. Note 2: Not too sure this number is too helpful, as links can become stale quickly. It is expected that text fragment links might not work after some time.
• Time spent in FragmentDirective::CreateTextDirective() (which was added in Bug 1934825, patch 2)
• Additionally: How many other matches were on the page for the target range? The correlation of this value with the total time might be interesting.
• Use counter: How often does FragmentDirective::CreateTextDirective() not find a text fragment.

Comment 1

[Andreas Farre [:farre]]

Documentation for adding Histograms and Scalars.

Adding telemetry needs data collection review.

To look at collected telemetry for the current session go to about:telemetry

Comment 2

[Roland Kossel]

Attachment: Bug 1942117 - Part 1: define metrics for text-fragments, r=jjaschke

Comment 3

[Roland Kossel]

Attachment: Bug 1942117 - Part 2: gather metrics for text fragments, r=jjaschke

Comment 4

[Roland Kossel]

Attachment: Bug 1942117 - Part 3: test metrics for text fragments, r=jjaschke

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be279d979df
Part 1: define metrics for text-fragments, r=jjaschke
https://hg.mozilla.org/integration/autoland/rev/2c3f00e616c8
Part 2: gather metrics for text fragments, r=jjaschke
https://hg.mozilla.org/integration/autoland/rev/3c9074e36c91
Part 3: test metrics for text fragments, r=jjaschke

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7be279d979df
https://hg.mozilla.org/mozilla-central/rev/2c3f00e616c8
https://hg.mozilla.org/mozilla-central/rev/3c9074e36c91