1942120 - glean_parser version used in the firefox-ios .venv does not work for some commits

Status: RESOLVED INCOMPLETE

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Charlie Humphreys [:charlie] [:jeddai]]

The issue seems to be as a result of glean_parser v16 generating code that is not appropriate for the given version of the Glean SDK being used. The generated code includes function parameters that are not present in the version of the Glean SDK being used.

Workaround:

1. Edit firefox-ios/bin/sdk_generator.sh to prevent it from updating the glean_parser version by commenting out these lines
2. Go into firefox-ios/.venv , and run ./bin/pip3.9 install glean_parser==15.2.1
3. run touch firefox-ios/Client/metrics.yaml
4. Close xcode
5. Delete ~/Library/Developer/Xcode/DerivedData
6. Re-launch xcode and build/run

I can provide additional details if it would be beneficial

Comment 1

[Jan-Erik Rediger [:janerik]]

Which firefox-ios is this happening on?
What Glean version is in use?
Can you post the resulting build error?

It didn't reproduce for me right now.

Comment 2

[Travis Long [:travis_]]

I think this happens right after a Glean_parser update, if I recall the setup conditions for this:

1. build for a version with a certain version of glean_parser, should build fine
2. Then git pull that includes a glean_parser version update in the sdk script, then this can happen

Like the .venv isn't getting cleared and the task triggered maybe because the task requires the metrics/ping.yaml files to be changed?

Comment 3

[Jan-Erik Rediger [:janerik]]

Then I'm still confused on what actually happened though.
We updated the Glean version in lockstep with the parser version here: https://github.com/mozilla-mobile/firefox-ios/commit/c5a2ff9299391fb6e50a4f865cd1279b7174d447#diff-7aae86e828ca7305f4b2bfaa1fb657ba7ed2042d0f1c1c1e5ab64aaec61a5348
And the current main branch uses these versions.

So I'm afraid that without an error log I'm not really sure what to look into.

Comment 4

[Jan-Erik Rediger [:janerik]]

As its hard to understand what exactly went wrong this time, I'm going to close this.
However if it comes up again we should re-open or file anew to look into it, preferably with error output or exact commits on which it happened.