Decouple about:welcome from the AboutNewTabChild JSWindowActor
Categories
(Firefox :: New Tab Page, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: perf-alert, Whiteboard: [hnt-trainhop])
Attachments
(1 file)
about:welcome currently relies on AboutNewTabChild. We want to decouple it, as the AboutNewTabChild is going to be moved into the newtab built-in add-on. Any functionality that about:welcome relies on should probably be cloned / moved over to AboutWelcomeChild.
|
||
Updated•7 months ago
|
|
Assignee | |
Comment 1•7 months ago
|
||
Digging into this further, we have to account for the case where browser.aboutwelcome.enabled is false (which is a configuration that our policy engine allows), which causes about:welcome to be an alias to about:newtab.
So I don't think we can do a full decouple here, but I think we can still clean this up a bit.
|
|
Assignee | |
Comment 2•7 months ago
|
||
This changes AboutNewTabService to have about:welcome (when
about:welcome is disabled) to redirect to about:home rather
than to have about:welcome be an alias to
about:home/about:newtab.
|
||
Comment 4•7 months ago
|
||
| bugherder | ||
|
||
Comment 5•6 months ago
|
||
Either this bug, or bug 1942144 lead to 15% improvement on a memory/AWSY sub-test (JS Tab closed [+30s, Forced GC])
|
||
Comment 6•6 months ago
|
||
(In reply to Pulsebot from comment #3)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/824e7411fa2c
Decouple about:welcome from AboutNewTabChild.
r=pdahiya,omc-reviewers,home-newtab-reviewers,thecount
Perfherder has detected a awsy performance change from push 824e7411fa2c9919c5798c9967402b544fe00811.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 3% | JS Tabs closed [+30s, forced GC] | windows11-64-2009-shippable-qr | fission tp6 | 45,181,058.67 -> 43,912,256.00 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 43635
For more information on performance sheriffing please see our FAQ.
Description
•