1942152 - [wpt-sync] Sync PR 50126 - Move construction/signing of additional bids from wptserve to JS tests.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50126 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50126
Details from upstream follow.

Orr Bernstein <[e-mail]> wrote:

Move construction/signing of additional bids from wptserve to JS tests.

The original implementation of the additional bid web platform tests
relied on signing the additional bids in the wptserve-hosted handler,
additional-bids.py, in the expectation that most of the construction of
the additional bids would take place server-side with minor input from
the JS-based tests on how the additional bids should be transformed for
each test case. As the tests have evolved, it's become clear that most

• and now all - of the construction and transformation of the additional
  bids is happening on the JS side of the boundary, leaving the
  wptserve-hosted handler with only significant responsibility: taking the
  fully-built additional bids and returning them, base64-encoded, in the
  appropriately formatted Ad-Auction-Additional-Bid response headers.

To achieve the shifting of responsibilities across this boundary, this
change moves the few remaining transformational functions of the
additional-bids.py into the additionalBidHelper in fledge-util.sub.js,
specifically enabling tests that verify the error behavior of
auction/seller/bid nonce mismatches, and replaces the Python-based
Ed25519 library with a JavaScript-based one. This change significantly
reduces the amount of communication needed across the boundary between
the tests and wptserve, enabling other test cases to be written more
easily.

Change-Id: I5a1d59731d3724407af04304cb0cb616cb64a957
Reviewed-on: https://chromium-review.googlesource.com/6165883
WPT-Export-Revision: 6b266c5787f8214183188bd10b02ce46f7818d0c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3014c73a1c80ae34e88b9c1a9369b1e32d99a119

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 191 tests and 1 subtests

## Status Summary

### Firefox
`OK`     : 190
`FAIL`   : 900
`ERROR`  : 1
`NOTRUN` : 1

### Chrome
`OK`     : 187
`PASS`   : 230
`FAIL`   : 652
`TIMEOUT`: 8
`NOTRUN` : 15

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3014c73a1c80ae34e88b9c1a9369b1e32d99a119)
[GitHub PR Head](https://wpt.fyi/results/?sha=731650d7d627e466699e031a139812997977dc56&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=731650d7d627e466699e031a139812997977dc56&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e68615487b8b
[wpt PR 50126] - Move construction/signing of additional bids from wptserve to JS tests., a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e68615487b8b