1942156 - Dialog is missing name and correct role

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Natalie Stroud [:nstroud]]

Attachment: Side by side with Nightly on the left showing the Create tab group dialog open. On the right is the NVDA speech viewer

Prerequisites:

Found in Nightly 136.0a1 (2025-01-15)(64-bit)
Open a few tabs in Nightly

STR:

1. Turn on NVDA
2. Open Firefox Nightly
3. Press Ctrl + L to move focus into the URL bar
4. Use Shift + TAB to move focus to the active tab
5. Use fn + Shift + F10 to open the context menu on the active tab
6. Use the Down arrow key to move focus to 'Add tab to New Group' and press ENTER
7. Observe NVDA output

Expected / Actual:

At this time, NVDA states that the role of 'Create tab group' is menu and it should be role (See: Tab Grouping Spec Figma). In addition, the dialog is missing an accessible name.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1942156 - Fix tab group dialog's role and name. r=dwalker,jswinarton

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75dd17d00bc
Fix tab group dialog's role and name. r=dwalker,tabbrowser-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c75dd17d00bc

Comment 4

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Nightly 137.0a1 (2025-02-06). The NVDA reads "Create tab group dialog" now.