Closed
Bug 1942171
Opened 6 months ago
Closed 6 months ago
MediaEngineWebRTCAudio.cpp is using deprecated AudioProcessingBuilder, should use BuiltinAudioProcessingBuilder
Categories
(Core :: WebRTC, task)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
137 Branch
| Tracking | Status | |
|---|---|---|
| firefox137 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
Details
Attachments
(7 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
An upcoming libwebrtc patch (1bb49e9ad4) removes the deprecated AudioProcessingBuilder. We should start using BuiltinAudioProcessingBuilder.
|
Assignee | |
Comment 1•6 months ago
|
||
|
|
Assignee | |
Comment 2•6 months ago
|
||
|
|
Assignee | |
Comment 3•6 months ago
|
||
|
|
Assignee | |
Comment 4•6 months ago
|
||
|
|
Assignee | |
Comment 5•6 months ago
|
||
|
|
Assignee | |
Comment 6•6 months ago
|
||
|
|
Assignee | |
Comment 7•6 months ago
|
||
|
||
Updated•6 months ago
|
Attachment #9463606 -
Attachment description: Bug 1942171 - add WebrtcEnvironmentWrapper. r?pehrsons! → Bug 1942171 - add WebrtcEnvironmentWrapper. r?ng!
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27c29807e6f4
add builtin_audio_processing_builder to the libwebrtc build. r=pehrsons,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/42d765f2f86a
generated moz.build files. r=pehrsons,ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/329121af73e1
remove unused AudioProcessingBuilder from PeerConnectionCtx.cpp r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/011c5b671f21
add WebrtcEnvironmentWrapper. r=ng
https://hg.mozilla.org/integration/autoland/rev/f43cfc28f31a
use BuiltinAudioProcessingBuilder instead of deprecated AudioProcessingBuilder. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/40b515d9bb82
set WebrtcEnvironmentWrapper in TestAudioInputProcessing. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/2c7259f7600f
use WebrtcEnvironmentWrapper in WebrtcCallWrapper. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ea43310eb5e7
apply code formatting via Lando
|
||
Comment 9•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/27c29807e6f4
https://hg.mozilla.org/mozilla-central/rev/42d765f2f86a
https://hg.mozilla.org/mozilla-central/rev/329121af73e1
https://hg.mozilla.org/mozilla-central/rev/011c5b671f21
https://hg.mozilla.org/mozilla-central/rev/f43cfc28f31a
https://hg.mozilla.org/mozilla-central/rev/40b515d9bb82
https://hg.mozilla.org/mozilla-central/rev/2c7259f7600f
https://hg.mozilla.org/mozilla-central/rev/ea43310eb5e7
Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox137:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•