Closed Bug 1942190 Opened 1 month ago Closed 1 month ago

Toggle 'layout.details.force-block-layout' to 'false' in Nightly

Categories

(Core :: Layout: Form Controls, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Let's toggle 'layout.details.force-block-layout' to 'false' in a Nightly-only way, to get some testing for that configuration before we're ready to release.)

bug 1941406 is where we'll let the pref-flip ride the trains to release; but first let's toggle it for Nightly-only, out of caution and to give us some time to implement ::details-content (bug 1901037) before letting this go to release. See bug 1941406 comment 8 for some thoughts on why it's maybe worth waiting on that piece. I'm not aware of anything else that's blocking this feature beyond that.

Also remove a trivial reftest that was checking for the legacy behavior; this
test fails with the pref-flip. The next patch in this series will add a new
WPT that exercises the same scenario as in the removed reftest, plus a bunch of
related scenarios.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

This test passes in Firefox (only with the previous patch in this series),
Chrome 134 dev, and Safari Tech Preview 18.2.

This test leaves ::details-content unstyled, which per spec means that the
::details-content should generate a 'display:block' wrapper around the
details-text. The reference case mimics this by simply adding an unstyled
div around that text.

This test passes in Chrome 134 dev and Safari Tech Preview 18.2.

It fails in Firefox because Firefox doesn't support ::details-content yet;
and in particular, Firefox doesn't automatically generate any wrapper-box for
that pseudo-element, and the lack-of-that-box leads to the wrong rendering.

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da967a5c389b part 1: Toggle the pref to let HTML <details> element be given custom 'display' values, on Nightly only for now. r=emilio,TYLin https://hg.mozilla.org/integration/autoland/rev/1e3dec2f84de part 2: Add WPT to test 'details'/'summary' with display:inline and inline-block. r=TYLin https://hg.mozilla.org/integration/autoland/rev/5a74fd9392ba part 3: Add variant of previous patch's details/summary WPT without any special styling on ::details-content. r=TYLin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50134 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Upstream PR merged by moz-wptsync-bot
Regressions: 1942768
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: