1942280 - [wpt-sync] Sync PR 50129 - Cookie Store API - Add tests for creation url, control characters, default secure

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50129 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50129
Details from upstream follow.

Rupin Mittal <[e-mail]> wrote:

Cookie Store API - Add tests for creation url, control characters, default secure

Added tests:

1. Check that set/get/getAll are using the context's creation URL
2. Check that set fails if certain control characters are present in the name or value
3. Check that CookieListItem is secure by default (we want to test this property individually since the other tests in set_arguments check other properties first--so failing one of the earlier properties means we never check the secure property)

Changed tests:

1. There are two tests in set_arguments and delete_arguments that pass in the result of get() to delete(). These tests indirectly depend on the domain property. But Safari/Mozilla don't support domain being returned by get(). So we change these tests to not rely on domain. The test still passes for Chrome.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4179eca523c31562678b516641ab50eccae946cc

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 8 tests and 50 subtests

Status Summary

Firefox

OK : 8
PASS: 126
FAIL: 26

Chrome

OK : 8
PASS: 152

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /cookie-store/cookieListItem_attributes.https.any.serviceworker.html [wpt.fyi]
  • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS)
  • CookieListItem - secure defaults to true: FAIL (Chrome: PASS)
• /cookie-store/cookieListItem_attributes.https.any.html [wpt.fyi]
  • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS)
  • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS)
  • CookieListItem - secure defaults to true: FAIL (Chrome: PASS)
• /cookie-store/cookieStore_set_arguments.https.any.serviceworker.html [wpt.fyi]
  • cookieStore.set default domain is null and differs from current hostname: FAIL (Chrome: PASS)
  • cookieStore.set adds / to path that does not end with /: FAIL (Chrome: PASS)
• /cookie-store/cookieStore_set_arguments.https.any.html [wpt.fyi]
  • cookieStore.set default domain is null and differs from current hostname: FAIL (Chrome: PASS)
  • cookieStore.set adds / to path that does not end with /: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b80c2252ca
[wpt PR 50129] - Cookie Store API - Add tests for creation url, control characters, default secure, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d5b80c2252ca