Closed Bug 1942301 Opened 5 months ago Closed 5 months ago

fips/cavs_scripts fails on windows

Categories

(NSS :: Test, defect)

Product:
NSS
Component:
Test
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jcristau, Assigned: jcristau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1942301 - fix fips test failure on windows.
48 bytes, text/x-phabricator-request
Details | Review

Since bug 1831552, windows fips tests are failing:

********************Running aesgcm tests
>>>>>  gcmDecrypt128
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmDecrypt128.rsp: empty
>>>>>  gcmDecrypt192
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmDecrypt192.rsp: empty
>>>>>  gcmDecrypt256
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmDecrypt256.rsp: empty
>>>>>  gcmEncryptExtIV128
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmEncryptExtIV128.rsp: empty
>>>>>  gcmEncryptExtIV192
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmEncryptExtIV192.rsp: empty
>>>>>  gcmEncryptExtIV256
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/AES_GCM/resp/gcmEncryptExtIV256.rsp: empty
CAVS test aesgcm had 6 failure(s)
********************Running ecdsa tests
>>>>>  KeyPair
>>>>>  PKV
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/ECDSA2/resp/PKV.rsp: empty
>>>>>  SigGen
>>>>>  SigVer
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/ECDSA2/resp/SigVer.rsp: empty
CAVS test ecdsa had 2 failure(s)
********************Running hmac tests
>>>>>  HMAC
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/HMAC/resp/HMAC.rsp: empty
CAVS test hmac had 1 failure(s)
********************Running kas tests
>>>>>  KASFunctionTest_ECCEphemeralUnified_NOKC_ZZOnly_init
>>>>>  KASFunctionTest_ECCEphemeralUnified_NOKC_ZZOnly_resp
>>>>>  KASValidityTest_ECCEphemeralUnified_NOKC_ZZOnly_init
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/KAS/resp/KASValidityTest_ECCEphemeralUnified_NOKC_ZZOnly_init.rsp: empty
>>>>>  KASValidityTest_ECCEphemeralUnified_NOKC_ZZOnly_resp
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/KAS/resp/KASValidityTest_ECCEphemeralUnified_NOKC_ZZOnly_resp.rsp: empty
>>>>>  KASFunctionTest_FFCEphem_NOKC_ZZOnly_init
>>>>>  KASFunctionTest_FFCEphem_NOKC_ZZOnly_resp
>>>>>  KASValidityTest_FFCEphem_NOKC_ZZOnly_init
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/KAS/resp/KASValidityTest_FFCEphem_NOKC_ZZOnly_init.rsp: empty
>>>>>  KASValidityTest_FFCEphem_NOKC_ZZOnly_resp
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/KAS/resp/KASValidityTest_FFCEphem_NOKC_ZZOnly_resp.rsp: empty
CAVS test kas had 4 failure(s)
********************Running tls tests
>>>>>  tls
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/KDF135/resp/tls.rsp: empty
CAVS test tls had 1 failure(s)
********************Running ike tests
>>>>>  ikev1_dsa
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/IKE/resp/ikev1_dsa.rsp: empty
>>>>>  ikev1_psk
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/IKE/resp/ikev1_psk.rsp: empty
>>>>>  ikev2
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/IKE/resp/ikev2.rsp: empty
CAVS test ike had 3 failure(s)
********************Running rng tests
>>>>>  Hash_DRBG
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/DRBG800-90A/resp/Hash_DRBG.rsp: empty
CAVS test rng had 1 failure(s)
********************Running sha tests
>>>>>  SHA1ShortMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA1ShortMsg.rsp: empty
>>>>>  SHA224ShortMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA224ShortMsg.rsp: empty
>>>>>  SHA256ShortMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA256ShortMsg.rsp: empty
>>>>>  SHA384ShortMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA384ShortMsg.rsp: empty
>>>>>  SHA512ShortMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA512ShortMsg.rsp: empty
>>>>>  SHA1LongMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA1LongMsg.rsp: empty
>>>>>  SHA224LongMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA224LongMsg.rsp: empty
>>>>>  SHA256LongMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA256LongMsg.rsp: empty
>>>>>  SHA384LongMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA384LongMsg.rsp: empty
>>>>>  SHA512LongMsg
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA512LongMsg.rsp: empty
>>>>>  SHA1Monte
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA1Monte.rsp: empty
>>>>>  SHA224Monte
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA224Monte.rsp: empty
>>>>>  SHA256Monte
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA256Monte.rsp: empty
>>>>>  SHA384Monte
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA384Monte.rsp: empty
>>>>>  SHA512Monte
sed: -e expression #3, char 0: no previous regular expression
/d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests/SHA/resp/SHA512Monte.rsp: empty
CAVS test sha had 15 failure(s)
fips.sh: #23: NIST CAVS test /d/task_173703348229375/tests_results/security/localhost.1/fips/cavs/tests - FAILED

Before that, the validate1.sh script was silently exiting 0 due to missing sum command.

On windows, the CR character in the script doesn't get passed to the sed
command, so it only sees an empty expression and errors out. Pass \r
instead.
And add set -e to avoid silent failures.

Assignee: nobody → jcristau
Status: NEW → ASSIGNED

fix fips test failure on windows. r=nss-reviewers,nkulatova
https://hg.mozilla.org/projects/nss/rev/c14a8066de6c44a07e89aa65d23380c725a5e350

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: