1942329 - New wpt failures in /css/css-values/rlh-on-root-lengths.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 50136 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-values/rlh-on-root-lengths.html [wpt.fyi]
  • Non font or line-height properties on :root should resolve rlh against :root line-height: FAIL (Chrome: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1942313 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

I think the spec changed here, but here is the place to tweak: https://searchfox.org/mozilla-central/rev/ef34dd879ef8d4a0f3d68d371d23caebcd8fef65/servo/components/style/values/specified/length.rs#410

Might be a good second bug?

Comment 2

[Ruhan]

Hi, can I take this bug?

From my understanding the problem is that when computing rlh on :root, we are using the default line‑height instead of the :root element’s actual line‑height, which is causing the failed tests. Does that sound right or is there something I'm missing?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Yes that sounds right, and please go ahead!

Comment 4

[Ruhan]

Attachment: Bug 1942329 - Resolve rlh units using the computed line_height_base on the root element instead of default style. r=emilio

Comment 5

[Ruhan]

Hi, I wanted to check in regarding the changes I submitted. I changed the code to call builder.calc_line_height with the line_height_base when is_root_element is true, instead of relying on the default style’s font. I tested the patch locally on my Mac. The wpt test failed on the original code but now passes after my changes. However, I’m not sure how to run the test across different devices or platforms. Let me know what you think and if there is anything else I can do for this bug.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Thanks, looks good. I pushed it to our automation here: https://treeherder.mozilla.org/jobs?repo=try&revision=dc7470e9515c57b4fd74942126a5bfc2f6daf7c8

You also need to mark the test as passing by removing this file: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/css-values/rlh-on-root-lengths.html.ini

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4774563617f
Resolve rlh units using the computed line_height_base on the root element instead of default style. r=emilio

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b4774563617f