Closed Bug 1942392 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 50157 - Migrate 2d.canvas.host.size.attributes.* to the new canvas WPT generator

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50157 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50157
Details from upstream follow.

Jean-Philippe Gravel <jpgravel@chromium.org> wrote:

Migrate 2d.canvas.host.size.attributes.* to the new canvas WPT generator

This test uses different types of newline characters, like \n, \r and
\f. The indent Jinja filter used by the test template 1 was dropping
all of these, replacing them with normal newlines. This looks like a
bug in Jinja: the indent filter could easily be made to preserve
newline types. This CL overrides the default indent filter with a
version doing exactly that.

Bug: 40207206
Change-Id: I5ece8e0ce4199bb0c915e59131c26eed4ce58693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172748
Commit-Queue: Jean-Philippe Gravel \<jpgravel@chromium.org>
Reviewed-by: Yi Xu \<yiyix@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408116}

PR 50157 applied with additional changes from upstream: 3b77b60493c5c73b711d9ab3c8bb883e7209f2e4, d2068ff6535cc4d147284ee84a5d30056399cbad, 4a64fbc174f25cc43510d8f96705fdeec83b5b82
Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9dc1cdbecd66 [wpt PR 50157] - Migrate 2d.canvas.host.size.attributes.* to the new canvas WPT generator, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.