1942404 - Failed to play HEVC video with inband config change on MacOS

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Alastor Wu [:alwu]]

This test case will fail, we need more investigation to know why it can't be played, and whether this issue will affect other videos with inband config changes.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1942404 - part1 : make SPSIterator find the SPS in the ctor.

The current implementation of SPSIterator is incorrect; it requires
calling the ++ operator before accessing any SPS. The * operator
should allow access to the SPS immediately after the SPSIterator is created.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1942404 - part2 : compare SPS by its members, not using memcmp.

memcmp is unreliable due to (1) padding bytes (2) non-POD Members,
so better to compare their members directly.

Depends on D235526

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1942404 - part3 : only update changed SPS/PPS/VPS nalu for extradata.

When recreating a decoder, the VideoToolbox decoder requires extradata containing SPS, PPS,
and VPS to successfully initialize a DecompressionSession.

The current implementation replaces the extradata when a different SPS is detected but does
not ensure that all three NALUs (SPS, PPS, and VPS) are present in the new extradata. For
example, in hevc_white_red_frames.mp4, the initial extradata contains all required NALUs,
but the inband extradata only includes an SPS without the PPS or VPS. Using such incomplete
extradata to recreate the decoder will result in a failure to create the DecompressionSession.

To resolve this, we should update only the differing NALUs to ensure all essential information
is retained in the extradata.

Depends on D235527

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1942404 - part4 : enable testHEVCInbandConfigChange.

Depends on D235528

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1942404 - part5 : add gtest for SPSIterator.

Depends on D235529

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cea7ede5ec9
part1 : make SPSIterator find the SPS in the ctor. r=padenot
https://hg.mozilla.org/integration/autoland/rev/e85efe0deebf
part2 : compare SPS by its members, not using memcmp. r=padenot
https://hg.mozilla.org/integration/autoland/rev/7db794a2c51f
part3 : only update changed SPS/PPS/VPS nalu for extradata. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c0e426038ce1
part4 : enable testHEVCInbandConfigChange. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/228ff31dd429
part5 : add gtest for SPSIterator. r=media-playback-reviewers,padenot

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3cea7ede5ec9
https://hg.mozilla.org/mozilla-central/rev/e85efe0deebf
https://hg.mozilla.org/mozilla-central/rev/7db794a2c51f
https://hg.mozilla.org/mozilla-central/rev/c0e426038ce1
https://hg.mozilla.org/mozilla-central/rev/228ff31dd429