1942411 - [wpt-sync] Sync PR 50159 - Get started cleaning up interesttarget implementation [1/N]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50159 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50159
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Get started cleaning up interesttarget implementation [1/N]

This is the first in a series of patches to clean up and update the
interesttarget implementation to match recent OpenUI discussions.

This CL:

• Gets rid of interestaction. See the large comment posted here:
  https://github.com/openui/open-ui/issues/1064#issuecomment-2581511411
• Adds a connection to InterestLost when elements are de-focused.
• Adds support (tentatively) for dialogs being shown modally.
• Remove keyboard/focus support for interesttarget. This will
  get re-added later in its new form, via a hotkey rather than
  focus.

Bug: 326681249
Change-Id: I26f07a00c4fb1d2b1da92b64d91f330c02a11468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166890
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: David Baron \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1408202}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f0cf6cfbee05cbfd6cd2e443b2ee2e27d1abcf7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 7
PASS : 2
FAIL : 24
ERROR: 1

Chrome

OK : 7
PASS : 9
FAIL : 17
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/the-button-element/interest-target/interestelement-interface.tentative.html [wpt.fyi]
  • interestTargetElement reflects interestee HTML element: FAIL (Chrome: PASS)
  • interestTargetElement reflects set value: FAIL (Chrome: PASS)
  • interestTargetElement reflects set value across shadow root into light dom: FAIL (Chrome: PASS)
  • interestTargetElement does not reflect set value inside shadowroot: FAIL (Chrome: PASS)
  • interestTargetElement does not reflect invalid value: FAIL (Chrome: PASS)
  • interestTargetElement throws error on assignment of non Element: FAIL (Chrome: PASS)
• /html/semantics/the-button-element/interest-target/interestevent-dispatch-shadow.tentative.html [wpt.fyi]
  • InterestEvent propagates across shadow boundaries retargeting invoker source: FAIL (Chrome: FAIL)
  • cross shadow InterestEvent retargets interestee to host element: FAIL (Chrome: FAIL)
• /html/semantics/the-button-element/interest-target/interestevent-interface.tentative.html [wpt.fyi]
  • source is readonly defaulting to null: FAIL (Chrome: FAIL)
  • InterestEventInit properties set value (manual event): FAIL (Chrome: FAIL)
  • InterestEventInit properties set value (beforetoggle event): FAIL (Chrome: FAIL)
  • InterestEventInit properties set value (toggle event): FAIL (Chrome: FAIL)
  • source set to undefined: FAIL (Chrome: FAIL)
  • source set to null: FAIL (Chrome: FAIL)
  • source set to false: FAIL (Chrome: FAIL)
  • source set to true: FAIL (Chrome: FAIL)
  • source set to {}: FAIL (Chrome: FAIL)
  • source set to non-Element EventTarget: FAIL (Chrome: FAIL)
• /html/semantics/the-button-element/interest-target/interesttarget-anchor-event-dispatch.tentative.html [wpt.fyi]
  • InterestEvent dispatches on anchor hover: FAIL (Chrome: FAIL)
• /html/semantics/the-button-element/interest-target/interesttarget-area-event-dispatch.tentative.html [wpt.fyi]
  • InterestEvent dispatches on area hover: FAIL (Chrome: FAIL)
• /html/semantics/the-button-element/interest-target/interesttarget-button-event-dispatch.tentative.html [wpt.fyi]
  • InterestEvent dispatches on button hover: FAIL (Chrome: FAIL)
  • event dispatches if interestee is non-HTML Element: FAIL (Chrome: FAIL)
• /html/semantics/the-button-element/interest-target/interesttarget-on-popover-behavior.tentative.html [wpt.fyi]
  • hover interest invoking closed popover opens: FAIL (Chrome: PASS)
• /html/semantics/the-button-element/interest-target/interesttarget-svg-a-event-dispatch.tentative.html [wpt.fyi]: ERROR (Chrome: ERROR)
  • InterestEvent dispatches on svg a hover: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e539edad2b5f
[wpt PR 50159] - Get started cleaning up interesttarget implementation [1/N], a=testonly
https://hg.mozilla.org/integration/autoland/rev/7970483caf85
[wpt PR 50159] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e539edad2b5f
https://hg.mozilla.org/mozilla-central/rev/7970483caf85