1942435 - Dismissals don't work for Merino suggestions without Suggest features

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

Bug 1941100 regressed this: It removed dismissal handling from UrlbarProviderQuickSuggest because I thought it wasn't necessary, but that code path was also used for suggestions that don't have a Suggest feature, e.g., Merino suggestions like dynamic Wikipedia and navigational suggestions.

Comment 1

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:

This regresses functionality for users who have opted in to Merino, a.k.a. online Firefox Suggest. The fix is simple.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1942435 - Fix dismissals for Merino suggestions that aren't managed by a Suggest feature.

I don't think we have any tests specifically for Merino suggestions that don't
correspond to Suggest features, i.e., suggestions with a Merino provider that is
technically unrecognized by Firefox. Dynamic Wikipedia suggestions and
navigational suggestions (a.k.a. top sites) are two examples. So I added tasks
for both sponsored and nonsponsored suggestions to make sure they're disabled
when the relevant pref is disabled, in addition to testing this bug itself.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1941100

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d1459a367f7
Fix dismissals for Merino suggestions that aren't managed by a Suggest feature. r=daisuke

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3d1459a367f7