[wpt-sync] Sync PR 50171 - Resolve font-weight values with CSSLengthResolver
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 50171 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/50171
Details from upstream follow.
Даниил <sakhapov@chromium.org> wrote:
Resolve font-weight values with CSSLengthResolver
This CL adds clamping to [1, 1000] interval as per spec
https://drafts.csswg.org/css-fonts/#font-weight-prop in style builder
converter, as we now resolve calc() there as well.This CL leaves TODO for interpolation code, as now it resolves
units before interpolation.Bug: 40946458
Fixed: 386860174
Change-Id: I12092088aa21a001bbcd9ae4241a1dae8ca07825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172306
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Daniil Sakhapov \<sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408543}
Assignee | ||
Updated•27 days ago
|
Assignee | ||
Comment 1•27 days ago
|
||
Assignee | ||
Comment 2•27 days ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 1 tests and 3 subtests
Status Summary
Firefox
OK
: 1
FAIL
: 3
Chrome
OK
: 1
FAIL
: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-fonts/font-weight-sign-function.html [wpt.fyi]
- Property font-weight value 'calc(sign(1rem - 1px) * 10)':
FAIL
(Chrome:FAIL
) - Property font-weight value 'calc(sign(1rem - 1px) * -10000)':
FAIL
(Chrome:FAIL
) - Property font-weight value 'calc(sign(1rem - 1px) * 10000)':
FAIL
(Chrome:FAIL
)
- Property font-weight value 'calc(sign(1rem - 1px) * 10)':
https://hg.mozilla.org/mozilla-central/rev/d8cfac915011
https://hg.mozilla.org/mozilla-central/rev/b9a506162933
Description
•