1942655 - Split custom-away from other away/back commands in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At the moment custom-away is done as a special case within the cmdAway code. I think it is better to do it outside of that code, and then call that code if required.

Comment 1

[Ian Neal]

Attachment: 1942655-irc-custom-away-25321.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9460562 [details] [diff] [review]
1942655-irc-custom-away-25321.patch

Looks halfway great to me :)

Dislike a bit the use of the vars overrideAway and idleAway inside the sendToAllNetworks function but not much different from the old code. Vars are declard after the function is defined which is a bit confusing at first. Scope wise ok.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f4b25284cd98
Split custom-away from other away/back commands in cZ. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6774db9cbff1f3f07258e4896e43914e9ba721fc
Split custom-away from other away/back commands in cZ. r=frg a=frg