1942658 - Move the extraParams from the Nimbus search section to the search configuration section

Status: VERIFIED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

We want to move the extraParams section of the Nimbus search section across to the searchConfiguration section. This will allow for better feature splits of experiments - where all the ones relating directly to the search configuration are in their own section, and the others in the search section are feature related.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1942658 - Move the extraParams from the Nimbus search section to the search configuration section. r?#search-reviewers!

This will mean that the search section will be exclusively for features, and the configuration section will be items relating more to the configuration.
Hence this should provide a better split for experiments to be able to use.

Comment 2

[Mark Banner (:standard8)]

We should do some QA verification to ensure that the extraParams section still works correctly when run from the searchConfiguation feature (where it will live after the patches land). It'll take a day or two for nightly builds to get the patches & Nimbus to update, but I can set something up once that is done.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd11dcd0e242
Move the extraParams from the Nimbus search section to the search configuration section. r=search-reviewers,scunnane

Comment 4

[agoloman]

Backed out for causing bc failures @browser_searchModeSwitcher_basic.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91d5a0bcc10e
Move the extraParams from the Nimbus search section to the search configuration section. r=search-reviewers,scunnane

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/91d5a0bcc10e

Comment 7

[Adrian Florinescu [:aflorinescu]]

Using nimbus-preview + search-configv2 from stage-preview with 137.0a1, 136.0b6 - set with search experiment content:

• Test the extraParams variable

  • Control branch, additional parameter added extratag=non

  • Treatment branch, additional parameter added extratag=block

No issues found with the search experiment parameters and modified search engine. Tested also default engines, removal/restoration, telemetry, params, search codes.