1942910 - [wpt-sync] Sync PR 50199 - Fix direction = "inherit" for offscreen canvas

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50199 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50199
Details from upstream follow.

Stephen Chenney <[e-mail]> wrote:

Fix direction = "inherit" for offscreen canvas

Offscreen canvas was not inheriting the direction attribute in the
way the spec described (which I am in the process of reworking). When
the direction is inherit the offscreen should try to get it from a
canvas element it is associated with, or the document if there is no
associated element (i.e. it was not transferred).

Also add tests for canvas text direction = "inherit"

Bug: 390272618
Change-Id: I5f862a4e2337b94b2eaa721733725a860872a824
Reviewed-on: https://chromium-review.googlesource.com/6173291
WPT-Export-Revision: dcb30f23b8b159f87f901ce66d1327842dbd2289

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=feffbbe574048c5e798f62d3101c5b7cd5b069b7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 8 tests

Status Summary

Firefox

PASS: 4[Gecko-windows11-32-2009-qr-debug] 5[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL: 3[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 4[Gecko-windows11-32-2009-qr-debug]

Chrome

PASS: 5
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/manual/text/canvas.2d.direction.inherit.disconnected.canvas.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/manual/text/canvas.2d.offscreen.transferred.direction.inherit.document.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/manual/text/canvas.2d.offscreen.transferred.direction.inherit.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/manual/text/canvas.2d.offscreen.worker.direction.html [wpt.fyi]: FAIL [Gecko-windows11-32-2009-qr-debug], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93b7a4970f05
[wpt PR 50199] - Fix direction = "inherit" for offscreen canvas, a=testonly
https://hg.mozilla.org/integration/autoland/rev/368ae8fb2339
[wpt PR 50199] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/93b7a4970f05
https://hg.mozilla.org/mozilla-central/rev/368ae8fb2339