1943002 - Create partner attributed stub installers

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

In bug 1941537, we dusted off partner attributions. This type of builds were proven to be working but were never shipped. With bug 1941537, we now ship regular Windows installers and macOS DMGs. We're still missing the stub installers. Let's add them.

Comment 1

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 1: Use get_artifact_prefix() instead of duplicating "releng/partner" r=bhearsum

Comment 2

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 2: Make _get_upstream_task_label_and_artifact() not duplicate the artifact file name r=bhearsum

Comment 3

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 3: Remove comment about removing locale as it does not apply to _get_upstream_task_label_and_artifact() r=bhearsum

Comment 4

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 4: Extract _get_attributed_build_configuration() r=bhearsum

Comment 5

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 5: Bubble up _get_artifact_file_name() r=bhearsum

Comment 6

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 6: Support multiple artifacts to attribute per task r=bhearsum

Comment 7

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 7: Attribute stub installers r=bhearsum

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e4dcdcc03f
part 1: Use get_artifact_prefix() instead of duplicating "releng/partner" r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/a36c81922d63
part 2: Make _get_upstream_task_label_and_artifact() not duplicate the artifact file name r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/12fcdfb1dc05
part 3: Remove comment about removing locale as it does not apply to _get_upstream_task_label_and_artifact() r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/361d3791ebdb
part 4: Extract _get_attributed_build_configuration() r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/91771d19088a
part 5: Bubble up _get_artifact_file_name() r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/5ecc59b90cb6
part 6: Support multiple artifacts to attribute per task r=bhearsum,taskgraph-reviewers,releng-reviewers
https://hg.mozilla.org/integration/autoland/rev/ee45e6534d2a
part 7: Attribute stub installers r=bhearsum,taskgraph-reviewers,releng-reviewers

Comment 9

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 1: Use get_artifact_prefix() instead of duplicating "releng/partner"

Original Revision: https://phabricator.services.mozilla.com/D235194

Comment 10

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 2: Make _get_upstream_task_label_and_artifact() not duplicate the artifact file name

Original Revision: https://phabricator.services.mozilla.com/D235195

Comment 11

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 3: Remove comment about removing locale as it does not apply to _get_upstream_task_label_and_artifact()

Original Revision: https://phabricator.services.mozilla.com/D235196

Comment 12

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 4: Extract _get_attributed_build_configuration()

Original Revision: https://phabricator.services.mozilla.com/D235197

Comment 13

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 5: Bubble up _get_artifact_file_name()

Original Revision: https://phabricator.services.mozilla.com/D235198

Comment 14

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 6: Support multiple artifacts to attribute per task

Original Revision: https://phabricator.services.mozilla.com/D235200

Comment 15

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 7: Attribute stub installers

Original Revision: https://phabricator.services.mozilla.com/D235201

Comment 16

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bedrock team will have to implement a mechanism to direct users to the right Windows build. Moreover, the beginning of the acquisition funnel is going to be negatively impact by the lack of stub installers.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: Tested in staging with Bedrock team. Risk is limited to partner repacks only. Standard Firefox builds are not modified at all.
• String changes made/needed: None
• Is Android affected?: no

Comment 17

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 1: Use get_artifact_prefix() instead of duplicating "releng/partner"

Original Revision: https://phabricator.services.mozilla.com/D235194

Comment 18

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 2: Make _get_upstream_task_label_and_artifact() not duplicate the artifact file name

Original Revision: https://phabricator.services.mozilla.com/D235195

Comment 19

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 3: Remove comment about removing locale as it does not apply to _get_upstream_task_label_and_artifact()

Original Revision: https://phabricator.services.mozilla.com/D235196

Comment 20

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 4: Extract _get_attributed_build_configuration()

Original Revision: https://phabricator.services.mozilla.com/D235197

Comment 21

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 5: Bubble up _get_artifact_file_name()

Original Revision: https://phabricator.services.mozilla.com/D235198

Comment 22

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 6: Support multiple artifacts to attribute per task

Original Revision: https://phabricator.services.mozilla.com/D235200

Comment 23

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 7: Attribute stub installers

Original Revision: https://phabricator.services.mozilla.com/D235201

Comment 24

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Bedrock team will have to implement a mechanism to direct users to the right Windows build. Moreover, the beginning of the acquisition funnel is going to be negatively impact by the lack of stub installers.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: Tested in staging with Bedrock team. Risk is limited to partner repacks only. Standard Firefox builds are not modified at all.
• String changes made/needed: None
• Is Android affected?: no

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/514b3fbb2438
https://hg.mozilla.org/releases/mozilla-beta/rev/feeb2234218a
https://hg.mozilla.org/releases/mozilla-beta/rev/f1eaa43c00e9
https://hg.mozilla.org/releases/mozilla-beta/rev/28ec5070a9b1
https://hg.mozilla.org/releases/mozilla-beta/rev/c92a2b11abbc
https://hg.mozilla.org/releases/mozilla-beta/rev/c90bc976a465
https://hg.mozilla.org/releases/mozilla-beta/rev/bde613d9667b

Comment 26

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/5329235a69e9
https://hg.mozilla.org/releases/mozilla-release/rev/660a33c22e41
https://hg.mozilla.org/releases/mozilla-release/rev/2355bd24528b
https://hg.mozilla.org/releases/mozilla-release/rev/42a62e2d4b57
https://hg.mozilla.org/releases/mozilla-release/rev/481ae82b71ca
https://hg.mozilla.org/releases/mozilla-release/rev/a02428b7369d
https://hg.mozilla.org/releases/mozilla-release/rev/e80d52c45396

Comment 27

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b2e4dcdcc03f
https://hg.mozilla.org/mozilla-central/rev/a36c81922d63
https://hg.mozilla.org/mozilla-central/rev/12fcdfb1dc05
https://hg.mozilla.org/mozilla-central/rev/361d3791ebdb
https://hg.mozilla.org/mozilla-central/rev/91771d19088a
https://hg.mozilla.org/mozilla-central/rev/5ecc59b90cb6
https://hg.mozilla.org/mozilla-central/rev/ee45e6534d2a

Comment 28

[Intermittent Failures Robot]

Summary

2 failures in 4035 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• gecko-decision: 2
  • opt: 2

Table

	no_variant
gecko-decision--/opt	2

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1943002&startday=2025-01-20&endday=2025-01-26&tree=all

Comment 29

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 3: Attribute stub installers instead of full ones r=bhearsum

Comment 30

[Johan Lorenzo [:jlorenzo] - On PTO - Back on March 18th]

Attachment: Bug 1943002 - part 4: Remove win64 platform from test config r=bhearsum

Comment 31

[Phabricator Automation]

Comment on attachment 9462170 [details]
Bug 1943002 - part 3: Attribute stub installers instead of full ones r=bhearsum

Revision D235756 was moved to bug 1943640. Setting attachment 9462170 [details] to obsolete.

Comment 32

[Phabricator Automation]

Comment on attachment 9462172 [details]
Bug 1943002 - part 4: Remove win64 platform from test config r=bhearsum

Revision D235758 was moved to bug 1943640. Setting attachment 9462172 [details] to obsolete.