194308 - add option to disable fastload

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Cathleen]

make it part of --disable-xul

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Putting the XPCOM part under --disable-xul doesn't make sense.

Comment 2

[Brendan Eich [:brendan]]

dougt hasn't been updating this bug, but I emailed him the other week about
making it a --disable-xpcom-fastload option, and he agreed.

/be

Comment 3

[Doug Turner (:dougt)]

moving minimo bugs to the new bugzilla product.

Comment 4

[Doug Turner (:dougt)]

Minimo may be using XUL now.  fastload seams like something you would want to
have.  brendan, is there any reason why I would want to disable fastload if I
was using XUL?

Comment 5

[Doug Turner (:dougt)]

i do not think this is important anymore.

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.1

removing the fastload, i see a small perf improvement.  it appears that writing to a flash-memory based file system is an very slow process.

Comment 7

[Benjamin Smedberg]

Comment on attachment 204642 [details] [diff] [review]
patch v.1

r=me, assuming there's another patch which actually does something useful with this flag ;-)

Comment 8

[Doug Turner (:dougt)]

Attachment: xpcom patch v.1

Comment 9

[Doug Turner (:dougt)]

Checking in xpcom/build/nsXPComInit.cpp;
/cvsroot/mozilla/xpcom/build/nsXPComInit.cpp,v  <--  nsXPComInit.cpp
new revision: 1.227; previous revision: 1.226
done
Checking in xpcom/io/Makefile.in;
/cvsroot/mozilla/xpcom/io/Makefile.in,v  <--  Makefile.in
new revision: 1.85; previous revision: 1.84
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1563; previous revision: 1.1562
done
Checking in config/autoconf.mk.in;
/cvsroot/mozilla/config/autoconf.mk.in,v  <--  autoconf.mk.in
new revision: 3.374; previous revision: 3.373
done

Fixed on trunk.

Comment 10

[cls]

Comment on attachment 204642 [details] [diff] [review]
patch v.1

+MOZ_ARG_DISABLE_BOOL(xpcom-fastload,
+[  --disable-xpcom-fastload           Disable XPCOM fastload support],
+    MOZ_NO_FAST_LOAD=,
+    MOZ_NO_FAST_LOAD=1)

The logic is backwards.  Specifying --disable-xpcom-fastload will unset MOZ_NO_FAST_LOAD when it should set it.

Btw, --disable-xpcom-obsolete suffers from the same problem.

Comment 11

[Doug Turner (:dougt)]

seawood, i just fixed both cases you mentioned.  

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1564; previous revision: 1.1563
done

Comment 12

[Doug Turner (:dougt)]

Attachment: patch for 1.8 branch

Comment 13

[Darin Fisher]

Comment on attachment 222412 [details] [diff] [review]
patch for 1.8 branch

It seems like there must be a lot of extra code that could be #ifdef'd away in a build with fastload disabled.  How about adding #ifdefs to those?  Or, is that a separate bug?

At any rate, this much looks good.  sr=darin