Closed
Bug 1943100
Opened 1 year ago
Closed 1 year ago
Fix some assertions in test_engine_selector_variants.js
Categories
(Firefox :: Search, task, P3)
Firefox
Search
Tracking
()
RESOLVED
FIXED
136 Branch
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 external file)
Testing out some of the new Rust based SearchEngineSelector with the desktop xpcshell-tests, I noticed that one of the tests has some incorrect set-up and assertions. The problem is that searchTermParamName is defined at the base level of the engine, rather than in the url.search details.
The existing JavaScript selector passes, because it is merging object properties without checking the structure. The Rust selector requires a strict structure, and so fails the test.
|
Assignee | |
Comment 1•1 year ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7e01ce85d05
Fix test assertions in test_engine_selector_variants.js. r=mcheang
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•