Closed Bug 1943146 Opened 1 month ago Closed 27 days ago

[wpt-sync] Sync PR 50226 - Fix old html.css selectors for popover/dialog

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50226 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50226
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix old html.css selectors for popover/dialog

When the overlay property was added, these rules should have
changed to simply look at whether the popover is a) a popover, and
b) in the top layer. This CL fixes a bug where it was possible for
a \<dialog popover open> to be in the top layer, but not have the
overlay:auto property, which caused painting issues.

Fixed: 388538944
Change-Id: I9665daef9f33ae61ea7bf82cb18429f14dab7d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185344
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409844}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc9aac1790f9 [wpt PR 50226] - Fix old html.css selectors for popover/dialog, a=testonly
Status: NEW → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.