Closed
Bug 1943147
Opened 9 months ago
Closed 6 months ago
No close button on sidebar of addon when sidebar.revamp = true
Categories
(Firefox :: Sidebar, defect, P2)
Tracking
()
VERIFIED
FIXED
140 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox-esr128 | --- | unaffected |
| firefox134 | --- | wontfix |
| firefox135 | --- | wontfix |
| firefox136 | --- | wontfix |
| firefox140 | --- | verified |
People
(Reporter: alice0775, Assigned: jsudiaman)
References
Details
(Keywords: blocked-ux, nightly-community, ux-consistency, Whiteboard: [fidefe-sidebar])
Attachments
(1 file)
Steps to reproduce:
- enable sidebar.revamp
- install addon such as tree style tab/update scanner
- open addon's sidebar
Actual results:
No close button on sidebar
Expected resukts:
Close button should be provided just like Bookmarks/History sidebar.
|
||
Comment 1•9 months ago
|
||
Ania, should we use the same header and close button in all sidebar extensions panels like we do for other panels?
Severity: -- → S3
Flags: needinfo?(asafko)
Keywords: blocked-ux
Priority: -- → P2
Whiteboard: [fidefe-sidebar]
|
||
Updated•9 months ago
|
|
||
Comment 2•8 months ago
|
||
Since this is existing behaviour it seems reasonable to do it for parity.
Flags: needinfo?(asafko)
|
|
||
Updated•7 months ago
|
Assignee: nobody → sclements
Status: NEW → ASSIGNED
|
|
||
Updated•7 months ago
|
Assignee: sclements → jsudiaman
|
Assignee | |
Comment 3•6 months ago
|
||
Pushed by jsudiaman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbc1626fa807
Add close button on sidebar of addon when sidebar.revamp = true r=sidebar-reviewers,desktop-theme-reviewers,kcochrane
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox140:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
|
||
Updated•6 months ago
|
|
||
Updated•5 months ago
|
QA Whiteboard: [qa-triage-done-c141/b140] [qa-verif-needed-c141/b140]
Flags: qe-verify+
|
|
||
Updated•5 months ago
|
QA Whiteboard: [qa-triage-done-c141/b140] [qa-verif-needed-c141/b140] → [qa-triage-done-c141/b140] [qa-ver-needed-c141/b140]
|
||
Updated•5 months ago
|
QA Contact: bhidecuti
|
|
||
Comment 6•5 months ago
|
||
I was able to reproduce the issue with an affected Firefox Nightly build from 2025-01-22, using Windows 11 and macOS 14, while following the steps described in Comment 0.
Verified as fixed using Firefox 140.0b2, on Windows 11, macOS 14 and Ubuntu 22.04. The Close button is now displayed in the sidebar for the tree style tab/update scanner add-ons
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c141/b140] [qa-ver-needed-c141/b140] → [qa-triage-done-c141/b140] [qa-ver-done-c141/b140]
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•