1943211 - SuggestFeature.shouldEnable shouldn't need to check the prefs in enablingPreferences

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

This is part of some Suggest refactoring/cleanup I'd like to do.

SuggestFeature has shouldEnable and enablingPreferences properties. Right now, each feature's shouldEnable implementation has to check the prefs in its enablingPreferences implementation, effectively duplicating that bit of code. That's unnecessary and the Suggest framework should do that automatically.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1943211 - Make SuggestFeature.shouldEnable check enablingPreferences.

This patch makes it unnecessary for most features to have to override
shouldEnable. Instead, the Suggest framework will check enablingPreferences
plus a new property called additionalEnablingPredicate. Summary:

• Include Nimbus variables in enablingPreferences
• Add a new property to SuggestFeature called additionalEnablingPredicate
• Make shouldEnable call enablingPreferences and
  additionalEnablingPredicate
• Remove shouldEnable implementations on most features

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61108343678e
Make SuggestFeature.shouldEnable check enablingPreferences. r=daisuke

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/61108343678e