Closed Bug 1943223 Opened 1 month ago Closed 1 month ago

Fix incorrect `unwrap()` usage

Categories

(Core :: Audio/Video: Playback, defect, P1)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1943223 - part1 : only call `unwrap()` once.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1943223 - part2 : check the resize event in testing.
48 bytes, text/x-phabricator-request
Details | Review

Once calling Result::unwrap(), the Result is not valid anymore. However, in some of our codes, we would still reuse the same Result causing incorrect result.

Once calling unwrap(), the Result is not valid anymore. The rest of
unwrap() will just return incorrect result.

Depends on D235249

Severity: -- → N/A
Priority: -- → P1
Summary: Fix H265::CompareExtraData → Fix incorrect `unwrap()` usage
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2bfdc2c0e17 part1 : only call `unwrap()` once. r=media-playback-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/ecfcd3f0ff1a part2 : check the resize event in testing. r=media-playback-reviewers,padenot

https://hg.mozilla.org/mozilla-central/rev/f2bfdc2c0e17
https://hg.mozilla.org/mozilla-central/rev/ecfcd3f0ff1a

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: