1943235 - non-unified build bustage in SandboxTestingChildTests.h

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Paul Bone [:pbone]]

0:01.69 /mnt/dev/moz/tlc/security/sandbox/common/test/SandboxTestingChildTests.h:654:5: error: use of undeclared identifier 'inet_pton'
0:01.70 654 | inet_pton(AF_INET6, "100::1", &addr.sin6_addr);
0:01.70 | ^
0:03.41 1 error generated.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1912626

:mail, since you are the author of the regressor, bug 1912626, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1943235 - Include arpa/inet.h in SandboxTestingChildTests.h r=gerard-majax

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c886fe7102
Include arpa/inet.h in SandboxTestingChildTests.h r=gerard-majax

Comment 4

[Max Inden]

Thank you for the patch Paul. Anything needed from my end?

Comment 5

[Paul Bone [:pbone]]

No, unless you think there's something wrong then I think it's done.

The needinfo was automated, because the bug was marked as a regression.

Thanks.

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/79c886fe7102

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pbone, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Paul Bone [:pbone]]

I don't think this needs to be in beta. AIUI non-unified builds are just something developers do. Or unified builds could change which sources are compiled together which could bring out similar problems.