1943262 - Refactor instantiation of nsEffectiveTLDService

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Description

[Mathieu Leplatre [:leplatrem]]

In Bug 1786310 we added a safety check around the service destructor.

The service gets instantiated and destroyed in different places, and as Valentin pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=1786310#c16

The component definition is marked as singletong but refers the constructor - which definitely won't return the same object for every call.

https://searchfox.org/mozilla-central/rev/9a66d18cb35595c89f499a1011c9dd7e573fce77/netwerk/build/components.conf#151-154

'singleton': True,
'type': 'nsEffectiveTLDService',
'headers': ['/netwerk/dns/nsEffectiveTLDService.h'],
'init_method': 'Init',

There seems to be some possible improvements and clean-up around the instantiation of this service.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1943262 - Refactor instantiation of nsEffectiveTLDService r=#necko

This ensures that the instantiation of the service always returns the
same singleton. I also changed calls to nsEffectiveTLDService::GetInstance
to use mozilla::components::EffectiveTLD::Service() instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b233889facbe
Refactor instantiation of nsEffectiveTLDService r=cookie-reviewers,anti-tracking-reviewers,permissions-reviewers,emz

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b233889facbe