1943328 - [wpt-sync] Sync PR 50241 - Re-enable and improve h264-unidirectional-codec.offer.https.html.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50241 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50241
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Re-enable and improve h264-unidirectional-codec.offer.https.html.

Update WPTs to reflect WebRTC roll of [1] and add a new test.

The H265 tests (both offer to send and offer to receive) now pass
(virtual because H265 is behind flag).

The H264 offer to send test no longer throws in setCodecPreferences()
and it successfully negotiates H264, however the test still fails for
reasons unrelated to the WebRTC fix, which is:

• H264 always offers profile-level-id=64001f (3.1) regardless of which
  level we ask it to offer, in my case 640034 (5.2).
  This is https://crbug.com/391750825.

The new test being added tests that even if we setCodecPreferences()
with a recvonly H264 codec on a sendrecv transceiver, we should still
offer H264 (but with a different level-id) because of codec filtering
being based on ignoring levels.

• This reveals a real bug in webrtc::IsSameRtpCodecIgnoringLevel that
  we should fix in a later CL. The problem is that it only ignores
  level for H265. Other codec comparison algorithms in WebRTC exists
  that do ignore levels for all codecs.

[1] https://webrtc-review.googlesource.com/c/src/+/374520

Bug: chromium:381407888
Change-Id: I2586abc01a955168cb9da1a7f0834a3e0aee049c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190353
Commit-Queue: Henrik Boström \<[e-mail]>
Auto-Submit: Henrik Boström \<[e-mail]>
Commit-Queue: Harald Alvestrand \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1410251}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=93502848bf4f606cfa49fe2c441b36a9487e09b5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PRECONDITION_FAILED: 3

Chrome

OK : 1
PASS : 1
FAIL : 1
PRECONDITION_FAILED: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/protocol/h264-unidirectional-codec-offer.https.html [wpt.fyi]
  • Offer to receive a recvonly H264 codec on a recvonly transceiver: PRECONDITION_FAILED (Chrome: PASS)
  • Offering a recvonly codec on a sendrecv transceiver: PRECONDITION_FAILED (Chrome: FAIL)
  • Offer to send a sendonly H264 codec on a sendonly transceiver: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42c9f63f4c87
[wpt PR 50241] - Re-enable and improve h264-unidirectional-codec.offer.https.html., a=testonly
https://hg.mozilla.org/integration/autoland/rev/5712c733c23c
[wpt PR 50241] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/42c9f63f4c87
https://hg.mozilla.org/mozilla-central/rev/5712c733c23c