1943339 - Improve react redux selectors in netmonitor to unnecessary renders

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[Julian Descottes [:jdescottes]]

Extracting some patches from 1849920 to land them earlier

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1943339 - [devtools] Fix memoization issues for netmonitor getColumns selector

The individual input selectors of reselect selectors should be as close as possible to the
data used by the selector, so that we can efficiently memoize the selector.
Since this selector returns an object which will always fail shallow comparisons it's important to
make sure we memoize efficiently.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1943339 - [devtools] Update netmonitor requests selectors to improve memoization

Depends on D234517

Update input selectors to memoize selector functions more efficiently.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1943339 - [devtools] Improve request selectors to avoid rebuilding filters for each request

Depends on D234519

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1943339 - [devtools] Avoid unnecessary renders due to blockedUrls prop

Depends on D234704

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f1de9a3ea3
[devtools] Fix memoization issues for netmonitor getColumns selector r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/deba5965ab0d
[devtools] Update netmonitor requests selectors to improve memoization r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/6f6c065d3c1d
[devtools] Improve request selectors to avoid rebuilding filters for each request r=ochameau,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/cb8f5ec29868
[devtools] Avoid unnecessary renders due to blockedUrls prop r=devtools-reviewers,bomsy

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b3f1de9a3ea3
https://hg.mozilla.org/mozilla-central/rev/deba5965ab0d
https://hg.mozilla.org/mozilla-central/rev/6f6c065d3c1d
https://hg.mozilla.org/mozilla-central/rev/cb8f5ec29868