1943345 - [wpt-sync] Sync PR 50243 - Adjust H264 profile-level-id test to avoid false failures.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50243 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50243
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Adjust H264 profile-level-id test to avoid false failures.

In preparation of fixing the bug that this test gives coverage for, it
needs to be updated in order to avoid it failing even when things are
working as expected.

If the codec is TRULY recvonly, then it is correct to only negotiate
VP8 and the assertion that H264 needs to be negotiated is wrong.

What we need is a profile-level-id that is "recvonly enough" to only be
listed in RTCRtpReceiver.getCapabilities() but for which we are actually
capable of sending, i.e. there exists some other profile-level-id in
RTCRtpSender.getCapabilities() that is not "==" equal but that is
equal if you "ignoreLevels = true".

64001f is one such profile that is commonly available (level 3.1). On
MacBook M1 Pro where we can send 5.2, this test is applicable.

This test will pass once this WebRTC CL lands:
https://webrtc-review.googlesource.com/c/src/+/374043

Bug: chromium:381407888
Change-Id: I4010d76092bf9b51b20f93e756e2dacf3e8665a3

Reviewed-on: https://chromium-review.googlesource.com/6194115
WPT-Export-Revision: 1f81c93b2ec4c3336f6b1822fa0c482058a91c62

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 50243 applied with additional changes from upstream: 78bb4169b248ffacecfbb15a77d9f283eff7f1ae

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a90ea70735eb886a2972aee275c8a54edc5d185

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PRECONDITION_FAILED: 3

Chrome

OK : 1
PASS : 1
PRECONDITION_FAILED: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/protocol/h264-unidirectional-codec-offer.https.html [wpt.fyi]
  • Offer to receive a recvonly H264 codec on a recvonly transceiver: PRECONDITION_FAILED (Chrome: PASS)
  • Offering a recvonly codec on a sendrecv transceiver: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED)
  • Offer to send a sendonly H264 codec on a sendonly transceiver: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef5e95a64891
[wpt PR 50243] - Adjust H264 profile-level-id test to avoid false failures., a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ef5e95a64891