Determine if we can (quietly) remove the partial GIFFT mirroring from Rust for timing_distribution metrics
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
People
(Reporter: chutten, Unassigned)
References
Details
In bug 1751448 we introduced a small, partial capability for timing_distribution metrics to mirror via GIFFT from Rust to legacy telemetry histograms.
Since bug 1751448, two things have happened.
- We introduced
labeled_timing_distributionmetrics and, wowzers, making GIFFT work for them was complicated severely by this. - We removed all the probes that currently use this capability (in bug 1943115)
...so maybe we can remove the capability and have {labeled_}timing_distribution's impl now be less of a special flower?
|
Reporter | |
Comment 1•9 months ago
|
||
The complication has come up most recently in bug 1941760 where I was adding GIFFT support for timing_distribution for the sample APIs. Adding support for labeled_timing_distribution as well was a step too far, so it was left out.
|
||
Comment 2•7 months ago
|
||
Well, I just filed bug 1954857 because a patch in bug 1953106 was not working as expected, and it took me a while to figure out that some specific methods were not mirroring. In my opinion GIFFT support should be consistent, or at the very least emit a warning when it drops data on the floor.
Description
•