Closed Bug 1943486 Opened 1 month ago Closed 25 days ago

[wpt-sync] Sync PR 50258 - Convert 2d.composite WPT tests using images to promise tests

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50258 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50258
Details from upstream follow.

Jean-Philippe Gravel <jpgravel@chromium.org> wrote:

Convert 2d.composite WPT tests using images to promise tests

This simplifies the offscreen and worker tests a lot, but it also
allows them to be implemented with the same structure as all other
tests, with three distinct sections:

  • Draw background.
  • Draw foreground.
  • Assert

This will help in the follow-up CLs, where these tests will be
migrated to the new test generator. Having the same structure will
allow all of these tests to have a shared base implementation.

The changes in gentestutils.py are pretty hacky, but it's hard to do
anything better given the state of this file. Since this script will be
deleted soon, there's no point in spending time to implement this in
a better way.

Bug: 40207206
Change-Id: I85eab5c12f328bda699d92ab8aecb804100e9d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192518
Reviewed-by: Andres Ricardo Perez \<andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel \<jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410563}

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 102 tests and 1 subtests

Status Summary

Firefox

OK : 102
PASS: 102

Chrome

OK : 102
PASS: 102

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4010b1c61581 [wpt PR 50258] - Convert 2d.composite WPT tests using images to promise tests, a=testonly
Status: NEW → RESOLVED
Closed: 25 days ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.