1943531 - netmonitor test context menu helper is duplicated and broken

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Julian Descottes [:jdescottes]]

This blocks me for writing tests properly for network overrides.

The 3 helpers:

• getContextMenuItem
• selectContextMenuItem
• maybeOpenAncestorMenu

Have been duplicated between netmonitor head.js and shared-head.js (the latter always taking over...)
They also rely on

if (parentPopup.state == "shown") {

Which doesn't work for XULPopupElement which has an "open" state. Not sure if "some" context menus might not be like this in netmonitor?
https://searchfox.org/mozilla-central/rev/f41e8cacb8e8ce254204e2526e98d49d024f1674/dom/chrome-webidl/XULPopupElement.webidl#155-161

 * Returns the state of the popup:
 *   closed - the popup is closed
 *   open - the popup is open
 *   showing - the popup is in the process of being shown
 *   hiding - the popup is in the process of being hidden
 */
readonly attribute DOMString state;

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1943531 - [devtools] Fix netmonitor test helpers to interact with the context menu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3e82a9ba9b9
[devtools] Fix netmonitor test helpers to interact with the context menu r=devtools-reviewers,nchevobbe

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d3e82a9ba9b9