194355 - delete user operation doesn't clean group mappings

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Tom Söderberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021212

If a bugzilla user is delete the group mappings for this user is not
affected/cleared.


Reproducible: Always

Steps to Reproduce:
1. create new user
2. dete this new user
3.

Actual Results:  
Sanity check complains


needs following statement to editusers.cgi:

    SendSQL("DELETE FROM user_group_map
             WHERE user_id=" . $userid);

Comment 1

[Max Kanat-Alexander]

Yep, you are indeed correct. What we're waiting on is the ability to make sure
that if a user's ever touched a bug, or if a user's a default owner, don't
delete them.

However, taking them out of all groups that they're in can't really hurt, I think.

So, I think we should take a patch on this one and then work on a better solution.

-M

Comment 2

[Joel Peshkin]

That would not be sufficient to make a user deletable.  

A user should never be deleted if that user has EVER reported or touched a bug.
 For practical purposes, the only way a user should be deletable is if the user
was the result of a typo on account creation and has never even logged in.

Comment 3

[GavinS]

Yes, the current code blindly (pretty much) just deletes a user from the
profiles table.

The improved code as part of the templatisation on bug#119485 improves this a
lot, and in doing so will fix this bug.

Comment 4

[Marc Schumann [:Wurblzap]]

Fixed by bug 119485 :)

Comment 5

[Shane H. W. Travis]

Resolving with the owner who actually did all the work.