Closed Bug 1943592 Opened 1 month ago Closed 25 days ago

[wpt-sync] Sync PR 50270 - Revert "Display resize observer loop notifications in devtools"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50270 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50270
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Revert "Display resize observer loop notifications in devtools"

This reverts commit 18cd9effcba79aea3d11169444c27279aec43b84.

Reason for revert: https://crbug.com/391393420

Original change's description:

Display resize observer loop notifications in devtools

Resize observer loop notifications errors that are not canceled should
appear in the devtools console so authors have some indication of the
error. This patch does this with two changes:

  1. A valid script state is used so the exception is not dropped in
    MainThreadDebugger::ExceptionThrown.
  2. A ScriptValue of the error message is used so a message appears in
    the console. Without a ScriptValue, MainThreadDebugger::ExceptionThrown
    will print "Uncaught null".

The console behavior is not specified so two tentative tests have been
added (Safari passes these). A TODO has been added to provide a useful
source location, as suggested by https://crbug.com/40667137#comment10.

Fixed: 40667137
Change-Id: Id20c977efd1fc03caba517ecec3bf3b0a9f53163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5970814
Auto-Submit: Philip Rogers \<pdr@chromium.org>
Reviewed-by: Andrey Kosyakov \<caseq@chromium.org>
Commit-Queue: Stefan Zager \<szager@chromium.org>
Reviewed-by: Stefan Zager \<szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1375538}

Bug: 391393420
Change-Id: I2234757d39320a6d120f7605f7fc3fe78344123d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197801
Auto-Submit: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Philip Rogers \<pdr@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Commit-Queue: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1410882}

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5204bdf4d7b8 [wpt PR 50270] - Revert "Display resize observer loop notifications in devtools", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 25 days ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.