1943648 - Testcase (with many XML files) spends 12s in parent-process and content-process on reloading in the background. Chrome reloads it instantly (slow blob URL unregisteration?)

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Mayank Bansal]

Attachment: XML.HTML

Open the attached testcase
Enter 50000 and press generate
Start the profiler and reload the page.

Nightly: https://share.firefox.dev/3Wy5Xrf (12s on parent-process + 12s on content-process)
Chrome: https://share.firefox.dev/42qK9RQ (instant)
Profile with all threads+ IO + IPC: https://share.firefox.dev/40O0vSd
Firefox to generate the xmls: https://share.firefox.dev/3CzEoGW
No idea how real worlds this testcase is. I thought of the testcase and asked chatpgpt to write the HTML. Feel free to INVALID/WONTFIX this bug.

Comment 1

[Mayank Bansal]

Profile with 100000 xml : https://share.firefox.dev/4hMwWrh

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Not sure why this is streams? I only see some blobs and layouts.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Back to performance for proper eyes.

Comment 4

[Bas Schouten (:bas.schouten)]

I believe DOM: File is the appropriate component.

Removing performance impact flag as this is a testcase and not and end-user reported issue.

Andrea might have ideas here.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1943648 - Reduce the number of IPC calls when unregistering blobURLs, r?smaug

Comment 6

[Mayank Bansal]

Profile of generating 50k XML's with all threads + All IO + IPC: https://share.firefox.dev/4gtFJgv

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

The testcase is very unrealistic, but at least we can fix some of it easily.

Comment 8

[Mayank Bansal]

yeah, that has been my driver for creating these testcase - to see if there is anything that is obviously bad/quadratic/easily fixable.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6927badc97c
Reduce the number of IPC calls when unregistering blobURLs, r=smaug

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ BlobURLProtocolHandler.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/82dfa270f6bbdb99fb5e0f377d4ac631ba2efe95

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:452:11: error: call to member function 'AppendInt' is ambiguous

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6017f3c8ff9
Reduce the number of IPC calls when unregistering blobURLs, r=smaug

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d6017f3c8ff9

Comment 14

[Mayank Bansal]

This is what i get with 50K XMLs on nightly: https://share.firefox.dev/417JjbG
So, much improved.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Looks like there are still some easy wins. ContentParent::mBlobURLs has rather slow data structure for this.
And ContentParent::ValidatePrincipal is taking lots of time. Both in the parent process. The first one might be easy to fix, the latter would need some thinking.