1943719 - Crash in [@ mozilla::MediaTrackGraphImpl::AppendMessage]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/ea702990-da90-46cc-a0b5-6ca4b0250123

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(mMainThreadTrackCount > 0 || mMainThreadPortCount > 0)

Top 10 frames:

0  XUL  mozilla::MediaTrackGraphImpl::AppendMessage(mozilla::UniquePtr<mozilla::Media...  dom/media/MediaTrackGraph.cpp:2170
1  XUL  mozilla::MediaTrackGraphImpl::DeviceChanged()::$_0::operator()() const::{lamb...  dom/media/MediaTrackGraph.cpp:1058
1  XUL  mozilla::detail::RunnableFunction<mozilla::MediaTrackGraphImpl::DeviceChanged...  xpcom/threads/nsThreadUtils.h:548
2  XUL  mozilla::RunnableTask::Run()  xpcom/threads/TaskController.cpp:714
2  XUL  mozilla::TaskController::RunTask(mozilla::Task*)  xpcom/threads/TaskController.cpp:218
2  XUL  mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::det...  xpcom/threads/TaskController.cpp:1143
3  XUL  mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detai...  xpcom/threads/TaskController.cpp:966
3  XUL  mozilla::TaskController::ProcessPendingMTTask(bool)  xpcom/threads/TaskController.cpp:650
3  XUL  mozilla::TaskController::TaskController()::$_0::operator()() const  xpcom/threads/TaskController.cpp:351
3  XUL  mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::...  xpcom/threads/nsThreadUtils.h:548

Comment 1

[Karl Tomlinson (:karlt)]

Perhaps something like the fix for bug 1586387 could be applied here also.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1608505

:padenot, since you are the author of the regressor, bug 1608505, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Paul Adenot (:padenot)]

Does comment 1 sound reasonnable here?

Comment 4

[Andreas Pehrson [:pehrsons]]

Yes, it would work.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1943719 - Repeat bailout logic after dispatching back to the main thread in MediaTrackGraph::DeviceChanged. r?pehrsons

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6724dbc6875
Repeat bailout logic after dispatching back to the main thread in MediaTrackGraph::DeviceChanged. r=pehrsons

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d6724dbc6875