Closed
Bug 1943795
Opened 29 days ago
Closed 27 days ago
Add BlockedSuggestions.blockResult() and don't set originalUrl unnecessarily
Categories
(Firefox :: Address Bar, task, P3)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
136 Branch
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(1 file)
This is part of some Suggest refactoring/cleanup I'd like to do.
We should add a BlockedSuggestions.blockResult() method so consumers don't need to pass in result.payload.originalUrl || result.payload.url.
I think it would also be a good idea to stop setting result.payload.originalUrl for results that don't neeed it, although that might be debatable. It's not a big deal right now though because the only suggestion type that sets it but doesn't need it is offline Wikipedia.
Basically I'm trying not to leak originalUrl in places that don't need to know about it.
|
||
Updated•29 days ago
|
|
Assignee | |
Comment 1•29 days ago
|
||
Depends on D235389
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d974952e15a1
Add BlockedSuggestions.blockResult() and don't set originalUrl unnecessarily. r=daisuke
|
||
Comment 3•27 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•