1943900 - Crash in [@ mozilla::net::nsHttpConnection::OnReadSegment]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/b3c48ffe-4e17-4740-8113-54f960250124

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(mTlsHandshaker->TlsHandshakeComplitionPending())

Top 10 frames:

0  xul.dll  mozilla::net::nsHttpConnection::OnReadSegment(char const*, unsigned int, unsi...  netwerk/protocol/http/nsHttpConnection.cpp:1553
1  xul.dll  mozilla::net::Http2Session::FlushOutputQueue()  netwerk/protocol/http/Http2Session.cpp:715
2  xul.dll  mozilla::net::Http2Session::ReadSegmentsAgain(mozilla::net::nsAHttpSegmentRea...  netwerk/protocol/http/Http2Session.cpp:2925
3  xul.dll  mozilla::net::nsHttpConnection::OnSocketWritable()  netwerk/protocol/http/nsHttpConnection.cpp:1651
4  xul.dll  mozilla::net::nsHttpConnection::OnOutputStreamReady(nsIAsyncOutputStream*)  netwerk/protocol/http/nsHttpConnection.cpp:2197
5  xul.dll  mozilla::net::nsSocketOutputStream::OnSocketReady(nsresult)  netwerk/base/nsSocketTransport2.cpp:528
6  xul.dll  mozilla::net::nsSocketTransport::OnSocketReady(PRFileDesc*, short)  netwerk/base/nsSocketTransport2.cpp:2154
7  xul.dll  mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDura...  netwerk/base/nsSocketTransportService2.cpp:1405
7  xul.dll  mozilla::net::nsSocketTransportService::Run()  netwerk/base/nsSocketTransportService2.cpp:1171
8  xul.dll  nsThread::ProcessNextEvent(bool, bool*)  xpcom/threads/nsThread.cpp:1153

This is a new crash that appeared on nightly, the first affected build ID is 20250123215052. This is most likely a regression given that the assertion has been in the code for a while, but I can't pinpoint it.

Comment 1

[Kershaw Chang [:kershaw]]

Probably caused by bug 1943011 (already backout).
Let's wait for few days and keep monitoring this.

Comment 2

[edgul]

Problem has disappeared since the backout, closing.