1943924 - [wpt-sync] Sync PR 50291 - Reland of "Store a PhysicalNaturalSizingInfo in LayoutImage"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50291 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50291
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Reland of "Store a PhysicalNaturalSizingInfo in LayoutImage"

Switch the current natural_size_ PhysicalSize to include also the
natural aspect ratio. Due to the dependency from LayoutVideo, it is also
updated to store its own natural dimensions rather than caching the
poster image dimensions.

Use the natural dimensions in LayoutImage to handle the call to
IncrementVisuallyNonEmptyPixelCount() directly rather than calling
LayoutImageResource::ImageSize(). This eliminates the last caller of
LayoutImageResource::ImageSize(), so remove it.

Reland update: Fix LayoutImage natural dimensions for the "represents
nothing" case. If the LayoutImage had no image associated and got an
ImageChanged() notification due to other reasons then it would compute
to no natural dimensions. Set the natural dimensions to 0x0 in this case
instead.

Bug: 41357911, 40866163
Change-Id: Icc8ed20cef1c2398a1d25ac7a4b58132327916d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198418
Commit-Queue: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1411544}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d680b4ac4303f17f04f0d4adafaa41ba414bd7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be188901dc6f
[wpt PR 50291] - Reland of "Store a PhysicalNaturalSizingInfo in LayoutImage", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/be188901dc6f