1943927 - The fade is visible when widget.macos.titlebar-blend-mode.behind-window is enabled on macOS.

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Yulia Popova]

Attachment: FadeSidebarExpanded

The fade is visible when widget.macos.titlebar-blend-mode.behind-window is enabled on macOS.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Yulia, can you attach the report from about:support? That has the details we'll need to investigate like preferences changed and the theme you are using etc

Comment 2

[Yulia Popova]

Sure. Attaching the report. I am using System Theme - Auto, since it is the only theme that works with translucency.

Comment 3

[Yulia Popova]

Attachment: Troubleshooting Information.pdf

Comment 4

[Stuart Colville [:muffinresearch]]

To reproduce this you'll likely need the following prefs set to true (which I don't think are apparent in the about:support output):

• widget.macos.titlebar-blend-mode.behind-window
• widget.macos.sidebar-blend-mode.behind-window (not-needed)
• browser.theme.native-theme

Plus the system theme - Auto enabled. Based on the screenshot the OS is set to the light theme.

I have noted a similar issue with a Dark OS theme, but the effect is variable based on what is behind the window. So for example for me with the dark OS theme and translucency enabled the dark shadow stands out, however conversely if I move the window over something darker the shadow will be almost invisible.

Comment 5

[Stuart Colville [:muffinresearch]]

Attachment: Screencast showing darker shadown more visible over lighter wallpaper areas

Comment 6

[Stuart Colville [:muffinresearch]]

If it's possible to reduce the transparency slightly that might reduce the variance? Alternatively would removing the shadows when translucency is enabled be an option to consider.

Another issue caused by the fades being more prominent is it's noticeable when they abruptly dissappear when scrolling to the top of the screen (see the screencast above for an example - though note the framerate of the gif is somewhat reduced).

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Yes, we should just use rgba() for the shadow with the system theme. We don't need to use the toolbar color there.

Comment 8

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1943927 - Don't use toolbox bgcolor for scroll fade gradient. r=#theme,#sidebar-reviewers

Comment 10

[Emilio Cobos Álvarez [:emilio]]

FWIW something like what I just attached seems to work nicely across both native and non-native themes. Thoughts?

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Tentatively taking after checking with Nikki :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa1a839303b3
Don't use toolbox bgcolor for scroll fade gradient. r=sidebar-reviewers,tabbrowser-reviewers,nsharpley

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aa1a839303b3