1944084 - [WebCompat Reporter] Only show menu item for reporter on valid URL links

Status: VERIFIED FIXED

(Firefox for Android :: General, task)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

On the legacy menu, the previous reporter would not be shown on local PDFs or about pages such as about:config. We should mirror this behaviour with the new reporter to reduce the amount of invalid reports being sent.

On the redesigned menu, if we want to implement the behaviour there as well, we should just aim to disable the button instead of removing the item (similar to what is currently done for reader mode and translations)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1944084 - Part 1: [WebCompat Reporter] Only enable menu item on valid URL links on redesigned menu

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1944084 - Part 2: [WebCompat Reporter] Only show menu item on valid URL links on legacy menu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99b8d36e43a2
Part 1: [WebCompat Reporter] Only enable menu item on valid URL links on redesigned menu r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/ba8a2fe7df7a
Part 2: [WebCompat Reporter] Only show menu item on valid URL links on legacy menu r=android-reviewers,007

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/99b8d36e43a2
https://hg.mozilla.org/mozilla-central/rev/ba8a2fe7df7a

Comment 6

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: AboutPagesNewMenu.jpg

This issue is verified as fixed on Firefox Nightly 137 (2025-02-05) on Samsung Galaxy S24 Ultra (Android 14).
Report broken site menu item in not displayed in the legacy menu and it is disabled in the redesigned menu when visiting about pages or opening a local PDF.

Comment 7

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: AboutPagesOldMenu.jpg

Comment 8

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: LocalPDFNewMenu.jpg

Comment 9

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: LocalPDFOldMenu.jpg

Comment 10

[Vasilica Tamas (Android QA) [:vtamas]]

This issue reproduces on Firefox 136 Beta 4 too (tested on Pixel 8 with Android 15 and Samsung S24 ultra with Android 14).

Comment 11

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Setting as wontfix because this isn't a release blocker for WebCompat Reporter